-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update core for ASDF standard 1.6.0 #422
Conversation
ec70c0d
to
631d542
Compare
@@ -1,14 +1,14 @@ | |||
%YAML 1.1 | |||
--- | |||
$schema: "http://stsci.edu/schemas/yaml-schema/draft-01" | |||
id: "http://stsci.edu/schemas/asdf/core/table-1.1.0" | |||
id: "http://stsci.edu/schemas/asdf/table/table-1.1.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since we're modifying this anyway, should we convert it to an asdf://asdf-format.org
URI?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm all for the change but would rather change (or attempt to change) all the tags at once. Perhaps that's a good target for 1.7.0?
can be cast to the given datatype without data loss. For | ||
exact datatype matching, set `exact_datatype` to `true`. | ||
allOf: | ||
- $ref: "http://stsci.edu/schemas/asdf/core/ndarray-1.1.0#/definitions/datatype" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah bummer. Such is life :)
54bcd4e
to
6932a40
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
One question, for my understanding - Is the effect of removing the "astronomy" tags from version_map-1.6.0
only that they are not included in the 1.6.0 standard? Does it affect in any way the ability to version them, e.g. read a file with an old astronomy tag and write it out using the current version?
Thanks for the review! The version maps have been largely replaced by the extension manifests. They are currently only used to determine the YAML (1.1) and file format (1.0) versions. asdf-format/asdf#1745 is work towards removing them (by instead defining these versions as constants). The tags listed in the version maps are unused in asdf (their usage was removed when the type index was removed in asdf 3.0). The tag selection for reading/writing is now entirely defined by the extensions (and manifests). To use |
6932a40
to
1241769
Compare
Removes
core/column
andcore/table
(replacing them withtable/column
andtable/table
).Removes all non-
core
tags from thecore
manifest, putting them in aastronomy
manifest.Removes
subclass_metadata
from 1.6.0.Update
asdf-schema
metaschema version to1.1.0
to pick upndarray-1.1.0
datatypes.